[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-07-12 Thread via GitHub
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1633559424 @mjsax thanks for notifying and that's ok :D Even I am not too up to date with the latest developments on Streams so in a way I dont think I was able to do full justification to

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-04-05 Thread via GitHub
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1497172421 > > Regarding system tests, is there a way to trigger via Jenkins ? (Sorry I am not aware of this). > >

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-04-03 Thread via GitHub
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1494691660 @guozhangwang , thanks for another round of review. Regarding system tests, is there a way to trigger via Jenkins ? (Sorry I am not aware of this). -- This is an automated message

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-03-29 Thread via GitHub
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1489661155 Thanks @guozhangwang , I addressed the comments. Let me know how the changes are looking now. Thanks! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-11-14 Thread GitBox
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1313754279 Thanks for the input @ableegoldman . I have made the changes based on my understanding. TBH, the code has changed a bit from what it was when I had last worked on it and I am not

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-10-13 Thread GitBox
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1277594018 > Hey @vamossagar12 , sorry for the seriously long silence on this -- it was important and I shouldn't have let it slip. Anyways I know you pointed me to a specific question about

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-03-11 Thread GitBox
vamossagar12 commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1065000470 @showuon made the changes. Let me know if these make sense now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-02-27 Thread GitBox
vamossagar12 commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1053493098 @showuon sure no worries! let me know whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-02-10 Thread GitBox
vamossagar12 commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1035711101 @ableegoldman . do you think this one is in a good shape? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2021-10-25 Thread GitBox
vamossagar12 commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-951125230 @ableegoldman / @guozhangwang plz review this whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please