vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1538450687
Thanks @viktorsomogyi . These are the ones we could find so far. We can
create follow up tickets if needed for any other executors within connect which
need to be closed this way and
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1537335506
The 2 connect related tests, `testSyncTopicConfigs() –
org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest`
and `testGetSinkConnectorOffsetsDifferentKafkaC
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1529384725
i think this PR. has a few more test errors. I would debug those and push a
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1527739912
@urbandan , i took the liberty and modified the
`shutdownExecutorServiceQuietly` to do a 2-phased shutdown as suggested in
JavaDocs. Also, modified `MemoryOffsetBackingStore, Source
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1521506051
I checked the flow again and ConnectException being thrown is handled from
`AbstractWorkerSourceTask#close` via the `Utils.closeQuietly` method which the
Worker#stop doesn't. Nonethe
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1521193360
@yashmayya , hmm MemoryOffsetBackingStore is used in Connect Standalone
IIUC. I am not totally aware of the historical context here of whether throwing
a ConnectException is valid or
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1517696428
Thanks @yashmayya . I just tried to include only the ones which have a
similar pattern. I think `SourceTaskOffsetCommitter` is something which can
also be modified but I missed that.
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1514537520
@yashmayya , @C0urante can you also review this small PR whenever you get
the chance? Thanlks!
--
This is an automated message from the Apache Git Service.
To respond to the messag
