vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1708174957
@C0urante bumping this one again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1651603163
> Thanks Sagar! I had a feeling the implementation for this would be a
little tricky, appreciate you taking a stab at it.
>
> I've left some inline suggestions and have some
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1650338567
Regarding
> Can we skip writes for tombstone records to the secondary store in our
second write (the one that takes place after we've written to the primary
store)? It's a
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1629387962
> Thanks @vamossagar12, this is looking much better now!
Thanks Yash.. I addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1624726819
`MirrorConnectorsIntegrationBaseTest#testOffsetTranslationBehindReplicationFlow`
is the only test which is relevant wrt the changes in this PR. I ran it
locally a couple of times
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1623807270
Thanks @yashmayya . I addressed the rest of the comments that you had.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1602461968
Thanks @yashmayya , I addressed your comments and added a response for one
of the questions. Let me know if that makes sense. Regarding
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1594109033
The build was aborted. But the failed tests seem unrelated as such to this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1573587479
> @vamossagar12 looks like there are checkstyle failures
Oh didn’t check that before taggging. Will check
--
This is an automated message from the Apache Git Service.
To
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1573519452
I will review the tests once they run. Still tagging the 2 reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
10 matches
Mail list logo
