[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-23 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-866794585 update PR & rebase trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-22 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-866504180 > Just one high-level comment: if all we need this for is the state, then maybe we should just add a method for that instead of exposing the `KafkaStreams` object directly.

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-22 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-865419554 Hey @ableegoldman, just a remind. Please take a look, when you have time. :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-21 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-865419554 Hey @ableegoldman, just a remind. Please take a look, when you have time. :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-05 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-855223713 @ableegoldman Please take a look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to