[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-29 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-719063925 Merged to 2.6 (cc @mimaison ) Thanks again for the contribution, @thake ! This is an automated message

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-29 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-718882348 _Finally_ merged that Jenkinsfile PR (seeing a lot of timeouts, but decided just to go ahead and merge it). Merged in the 2.6 branch, and now the tests are running! We

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714564666 Ahh, I already commented on https://github.com/apache/kafka/pull/9478, but I think now I see the motivation for that PR. If it was indeed just because there are internal

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-21 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-713659242 ... I'm not sure how to get Jenkins to test this PR. This is an automated message from the Apache Git Service.

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-21 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-713658911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-21 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-713654871 Hey, @mimaison , do you think we can get this into 2.6.1? This is an automated message from the Apache Git

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-21 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-713654459 Ah, it also looks like a bunch of tests fail due to EasyMock expectations being needed, and I also saw a couple of the null checks failling.