[GitHub] [kafka] xvrl commented on a diff in pull request #11998: KAFKA-13801: Kafka server does not respect MetricsReporter contract for dynamically configured reporters

2022-04-07 Thread GitBox
xvrl commented on code in PR #11998: URL: https://github.com/apache/kafka/pull/11998#discussion_r845459993 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -1813,14 +1812,20 @@ class TestMetricsReporter extends MetricsReporter with

[GitHub] [kafka] xvrl commented on a diff in pull request #11998: KAFKA-13801: Kafka server does not respect MetricsReporter contract for dynamically configured reporters

2022-04-06 Thread GitBox
xvrl commented on code in PR #11998: URL: https://github.com/apache/kafka/pull/11998#discussion_r844114172 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -800,12 +800,15 @@ class DynamicMetricsReporters(brokerId: Int, server: KafkaBroker) extends Reconf