[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-13 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r970342727 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/WorkerErrantRecordReporterTest.java: ## @@ -78,4 +68,41 @@ public void testGetFutures() {

[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-13 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r970342561 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -250,97 +258,90 @@ public void

[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-13 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r970342294 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -222,25 +224,31 @@ public void

[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-13 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r969848670 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTaskTest.java: ## @@ -78,155 +74,80 @@ public void tearDown() { public void

[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-13 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r969737990 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTaskTest.java: ## @@ -78,82 +78,41 @@ public void tearDown() { public void

[GitHub] [kafka] yashmayya commented on a diff in pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-09 Thread GitBox
yashmayya commented on code in PR #12615: URL: https://github.com/apache/kafka/pull/12615#discussion_r966947727 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTaskTest.java: ## @@ -162,71 +121,53 @@ public void stopBeforeStarting() { // now run