Re: [PR] KAFKA-16015: Fix custom timeouts overwritten by defaults [kafka]

2023-12-29 Thread via GitHub
divijvaidya commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871892425 backported to 3.7 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-16015: Fix custom timeouts overwritten by defaults [kafka]

2023-12-29 Thread via GitHub
divijvaidya merged PR #15030: URL: https://github.com/apache/kafka/pull/15030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16015: Fix custom timeouts overwritten by defaults [kafka]

2023-12-29 Thread via GitHub
divijvaidya commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871886450 Unrelated test failures ``` [Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest."testUngracefulRemoteCloseDuringHandshakeRead(Args).tlsProtocol

Re: [PR] KAFKA-16015: Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
sciclon2 commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871500486 thanks for your collaboration @divijvaidya I really appreciate it, all sorted!!! `➜ kafka git:(KAFKA-16015-bugfix) ✗ ./gradlew tools:test --tests LeaderElectionCommandTest.testAdminC

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871243698 Hey @sciclon2 , try something like this ``` @ClusterTest public void testAdminConfigCustomTimeouts() throws Exception { int defaultApiTimeoutMs = 24;

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437697827 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exceptio

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
sciclon2 commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871195223 hey @divijvaidya if you dont mind I need a bit of help ofr the test, I have created this: `@ClusterTest public void testAdminConfigCustomTimeouts() throws Exception {

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-27 Thread via GitHub
sciclon2 commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437137364 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exception {

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-27 Thread via GitHub
sciclon2 commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437137364 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exception {

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-27 Thread via GitHub
sciclon2 commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437137364 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exception {

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-22 Thread via GitHub
sciclon2 commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1434907926 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exception {

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-22 Thread via GitHub
divijvaidya commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1434893044 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exceptio

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-21 Thread via GitHub
pprovenzano commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1866442934 > @pprovenzano , I dont have permissions to merge the PR, so I guess somebody else eventually will do it, is that correct? thanks! I don't have them either. I've asked another t

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-20 Thread via GitHub
sciclon2 commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1865512396 @pprovenzano , I dont have permissions to merge the PR, so I guess somebody else eventually will do it, is that correct? thanks! -- This is an automated message from the Apache Git Ser

[PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-17 Thread via GitHub
sciclon2 opened a new pull request, #15030: URL: https://github.com/apache/kafka/pull/15030 ### Summary Basically when executing `kafka-leader-election.sh` the custom timeouts passed by the config file (--admin.config option) is not honoured. SO after [this investigation](https://issues.