omkreddy closed pull request #14556: [WIP]KAFKA-15444: Native docker image
URL: https://github.com/apache/kafka/pull/14556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #14556:
URL: https://github.com/apache/kafka/pull/14556#issuecomment-1980016226
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
ijuma commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1381192520
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
Makes sense, thanks.
--
This is an automated message from the Apache Git Serv
VedarthConfluent commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1381142228
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
It has been removed. These changes are part of KIP 975 PR raised here:
ijuma commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1380771281
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
Can we remove `confluent_kafka` from here then?
--
This is an automated messa
VedarthConfluent commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1375771218
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
This suggestion has been incorporated. Now we are using CLI scripts in
kagarwal06 commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1363544662
##
core/src/main/scala/kafka/Kafka.scala:
##
@@ -86,6 +86,10 @@ object Kafka extends Logging {
}
def main(args: Array[String]): Unit = {
+process(args)
+
ijuma commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1362884405
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
Can we not use the CLI tools that are included in the Apache Kafka project?
--
VedarthConfluent commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1361495859
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
@ijuma Confluent Kafka for Python -
https://github.com/confluentinc/c
ijuma commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1361488481
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
But why would we depend on a confluent kafka artifact.
--
This is an automate
VedarthConfluent commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1361487179
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
It seems like it's a typo. Updating it to `confluent-kafka`
--
Thi
ijuma commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1361476173
##
docker/test/requirements.txt:
##
@@ -0,0 +1,6 @@
+confluent_kafka
Review Comment:
This doesn't seem right.
--
This is an automated message from the Apache Git
ijuma commented on code in PR #14556:
URL: https://github.com/apache/kafka/pull/14556#discussion_r1361474850
##
core/src/main/scala/kafka/Kafka.scala:
##
@@ -86,6 +86,10 @@ object Kafka extends Logging {
}
def main(args: Array[String]): Unit = {
+process(args)
+ }
+
kagarwal06 opened a new pull request, #14556:
URL: https://github.com/apache/kafka/pull/14556
This PR includes the changes for `native-binary` docker image for Apache
Kafka
**NOTE 1** Hence this PR will be merged post merging
https://github.com/apache/kafka/pull/14552
**NOTE 2
14 matches
Mail list logo
