Re: [PR] Image test improvements [kafka]

2024-03-29 Thread via GitHub
ahuang98 commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1544932474 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -88,7 +101,7 @@ public class ClusterImageTest { setId(2). setEp

Re: [PR] Image test improvements [kafka]

2024-03-29 Thread via GitHub
ahuang98 commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1544930494 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -88,7 +101,7 @@ public class ClusterImageTest { setId(2). setEp

Re: [PR] Image test improvements [kafka]

2024-03-29 Thread via GitHub
jolshan commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1544929534 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -88,7 +101,7 @@ public class ClusterImageTest { setId(2). setEpo

Re: [PR] Image test improvements [kafka]

2024-03-29 Thread via GitHub
chia7712 commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1544339792 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -88,7 +101,7 @@ public class ClusterImageTest { setId(2). setEp

Re: [PR] Image test improvements [kafka]

2024-03-29 Thread via GitHub
chia7712 commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1544335647 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -88,7 +101,7 @@ public class ClusterImageTest { setId(2). setEp

Re: [PR] Image test improvements [kafka]

2024-03-28 Thread via GitHub
mimaison merged PR #15373: URL: https://github.com/apache/kafka/pull/15373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] Image test improvements [kafka]

2024-03-26 Thread via GitHub
mimaison commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1539799687 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -186,6 +264,19 @@ public void testImage2RoundTrip() { testToImage(IMAGE2);

Re: [PR] Image test improvements [kafka]

2024-03-26 Thread via GitHub
mimaison commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1539417806 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -186,6 +264,19 @@ public void testImage2RoundTrip() { testToImage(IMAGE2);

Re: [PR] Image test improvements [kafka]

2024-03-21 Thread via GitHub
mimaison commented on PR #15373: URL: https://github.com/apache/kafka/pull/15373#issuecomment-2012481246 @ahuang98 The [last CI](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15373/3/#showFailuresLink) run for this PR had a lot of test failures. I think if you rebase on trunk

[PR] Image test improvements [kafka]

2024-02-14 Thread via GitHub
ahuang98 opened a new pull request, #15373: URL: https://github.com/apache/kafka/pull/15373 More commit history and comments from https://github.com/apache/kafka/pull/14206 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Veri