Re: [PR] Introduce ELR [kafka]

2023-10-07 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1349612724 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1008,7 +1024,8 @@ ControllerResult alterPartition(

Re: [PR] Introduce ELR [kafka]

2023-10-07 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1349612624 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -328,13 +349,38 @@ public Optional build() { completeReassig

Re: [PR] Introduce ELR [kafka]

2023-10-07 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1349612504 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -362,6 +408,38 @@ private void setAssignmentChanges(PartitionChangeReco

Re: [PR] Introduce ELR [kafka]

2023-10-07 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1349612450 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -362,6 +408,38 @@ private void setAssignmentChanges(PartitionChangeReco

Re: [PR] Introduce ELR [kafka]

2023-10-07 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1349612437 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -328,13 +349,38 @@ public Optional build() { completeReassig

Re: [PR] Introduce ELR [kafka]

2023-10-06 Thread via GitHub
artemlivshits commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1349318665 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -328,13 +349,38 @@ public Optional build() { completeReassignm