Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna merged PR #15254: URL: https://github.com/apache/kafka/pull/15254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-2014715261 Build failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

clolov commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1529018575 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -190,7 +181,7 @@ public class TaskManagerTest {

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1528601954 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -190,7 +181,7 @@ public class TaskManagerTest {

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

ijuma commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1528552125 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -190,7 +181,7 @@ public class TaskManagerTest {

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

clolov commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1528403432 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -785,7 +776,6 @@ public void

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

clolov commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-2003726516 Heya @cadonna! This should be rebased, tests ought to be passing and all comments are addressed . Let me know if there is something else you would suggest improving! -- This is an

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

clolov commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1977164414 Ah, I remember why I didn't publicize this PR when I opened it @cadonna. I believe the EasyMock/Mockito weirdness will be solved if we first merge

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

clolov commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1976222841 I will have a look today, thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1510774397 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2403,15 +2383,18 @@ public void

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975962915 From a quick look, both PRs seem to do the same. I will try to have a look into this PR this week. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975956880 > There is a `1` missing. :) I meant #13897 Ah, OK. Now it makes sense! Let me have a look! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

ijuma commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975909858 There is a `1` missing. :) I meant https://github.com/apache/kafka/pull/13897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

cadonna commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975855514 > Not sure how this PR related to #3897 though. Is it a successor? @ijuma what relation between this PR and #3897 you are referring at? I do not see any connection between those

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

ijuma commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975226112 Not sure how this PR related to #3897 though. Is it a successor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

ijuma commented on PR #15254: URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975225882 Is this ready to review? @divijvaidya @cadonna Any chance you can help review this? Looks like there are only two tests in streams that still use mockito (and this is one of them). --

Re: [PR] KAFKA-14133: Move stateDirectory mock in TaskManagerTest to Mockito [kafka]

clolov commented on code in PR #15254: URL: https://github.com/apache/kafka/pull/15254#discussion_r1465053043 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -5153,14 +5128,14 @@ private void makeTaskFolders(final String...