Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-04 Thread via GitHub
lucasbru merged PR #15105: URL: https://github.com/apache/kafka/pull/15105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
nicktelford commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875335559 @lucasbru OK, my bad. It turns out I did a minor refactoring _after_ I ran the test suite yesterday that was so insignificant I didn't think I needed to run the tests again... Turns

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
lucasbru commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875033002 @nicktelford I'll rerun it. That being said, the last jobs on trunk have all finished within 3-5 hours, so this must be caused by either infrastructure or the code in this PR. --

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
nicktelford commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875025617 @lucasbru I think this is just the CI causing trouble again. The build passes locally. Is there a way to rerun the build without pushing more commits? -- This is an automated

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
lucasbru commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875023389 @nicktelford Seems like all build jobs timed out. Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-02 Thread via GitHub
nicktelford commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1873934211 @cadonna @mjsax @ableegoldman @lucasbru @wcarlson5 @bbejeck @vvcephei @guozhangwang This is part of KIP-892, and has been broken out into a separate PR to reduce the review

[PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-02 Thread via GitHub
nicktelford opened a new pull request, #15105: URL: https://github.com/apache/kafka/pull/15105 To support future use-cases that use different strategies for accessing RocksDB, we need to de-couple the RocksDB access strategy from the Column Family access strategy. To do this, we now