Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac merged PR #14845: URL: https://github.com/apache/kafka/pull/14845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on PR #14845: URL: https://github.com/apache/kafka/pull/14845#issuecomment-1845119315 The last build is pretty awful. I went through the list of all failed tests and I could not link any of them to the changes made in this PR. They are all unrelated. Therefore, I will merge

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on PR #14845: URL: https://github.com/apache/kafka/pull/14845#issuecomment-1843565757 It looks like the new failing tests are coming from https://github.com/apache/kafka/pull/14626. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1417658955 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -653,12 +653,15 @@ public DeadlineAndEpoch

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1416220626 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -653,12 +653,15 @@ public DeadlineAndEpoch

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1416142507 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -187,8 +190,6 @@ public CoordinatorResult commitOffset(

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on PR #14845: URL: https://github.com/apache/kafka/pull/14845#issuecomment-1840467329 @jolshan Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415313002 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -187,8 +190,6 @@ public CoordinatorResult commitOffset(

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415313002 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -187,8 +190,6 @@ public CoordinatorResult commitOffset(

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415310830 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -675,25 +675,25 @@ public void testValidateOffsetCommit() {

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415305714 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java: ## @@ -293,7 +326,11 @@ public void testReplayOffsetCommit() {

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415299461 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -1615,4 +1618,127 @@ public void

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415298403 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -833,13 +835,15 @@ public void validateOffsetCommit(

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1415287012 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -180,7 +185,78 @@ public OffsetMetadataManager build() { /**

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414703024 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -180,7 +185,78 @@ public OffsetMetadataManager build() {

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414697270 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -187,8 +190,6 @@ public CoordinatorResult commitOffset(

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414694924 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -675,25 +675,25 @@ public void testValidateOffsetCommit()

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414694054 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java: ## @@ -293,7 +326,11 @@ public void testReplayOffsetCommit() {

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414690648 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -1615,4 +1618,127 @@ public void

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414690195 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -833,13 +835,15 @@ public void validateOffsetCommit(

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414627867 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -180,7 +185,78 @@ public OffsetMetadataManager build() {

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414621182 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -180,7 +185,78 @@ public OffsetMetadataManager build() {

Re: [PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

jolshan commented on code in PR #14845: URL: https://github.com/apache/kafka/pull/14845#discussion_r1414610034 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -180,7 +185,78 @@ public OffsetMetadataManager build() {

[PR] KAFKA-14505; [2/N] Implement TxnOffsetCommit API [kafka]

dajac opened a new pull request, #14845: URL: https://github.com/apache/kafka/pull/14845 This PR is built on top of https://github.com/apache/kafka/pull/14844. e81db1e94bb51cf33cee353944722d5b5516729f could already be reviewed. This patch implements the TxnOffsetCommit API. When a