Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-05 Thread via GitHub
dajac merged PR #14882: URL: https://github.com/apache/kafka/pull/14882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-03 Thread via GitHub
vamossagar12 commented on PR #14882: URL: https://github.com/apache/kafka/pull/14882#issuecomment-1837429558 Looks like the newly added test `testRejoiningStaticMemberGetsAssignmentsBackWhenNewGroupCoordinatorIsEnabled` did not fail in the latest run. -- This is an automated message

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-01 Thread via GitHub
vamossagar12 commented on code in PR #14882: URL: https://github.com/apache/kafka/pull/14882#discussion_r1412299630 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -137,6 +137,98 @@ class ConsumerGroupHeartbeatRequestTest(cluster:

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-01 Thread via GitHub
dajac commented on code in PR #14882: URL: https://github.com/apache/kafka/pull/14882#discussion_r1412090130 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -137,6 +137,98 @@ class ConsumerGroupHeartbeatRequestTest(cluster:

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-01 Thread via GitHub
dajac commented on code in PR #14882: URL: https://github.com/apache/kafka/pull/14882#discussion_r1412090389 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -137,6 +137,98 @@ class ConsumerGroupHeartbeatRequestTest(cluster:

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-01 Thread via GitHub
vamossagar12 commented on PR #14882: URL: https://github.com/apache/kafka/pull/14882#issuecomment-1836078586 oh I see. Didn't realise that, sorry. The fact that I see this on the local as well means it's flaky.. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-01 Thread via GitHub
dajac commented on PR #14882: URL: https://github.com/apache/kafka/pull/14882#issuecomment-1836072757 @vamossagar12 Hum... `ERROR Unexpected error handling org.apache.kafka.server.AssignmentsManager$DispatchEvent@3909ac4e` is not related to the group coordinator. -- This is an automated

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-12-01 Thread via GitHub
vamossagar12 commented on PR #14882: URL: https://github.com/apache/kafka/pull/14882#issuecomment-1836000366 @dajac , I ran the test a few times on my laptop. It passes most of the times but sometimes fails with ```[2023-12-01 17:21:23,530] WARN [QuorumController id=3000] Performing

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-11-30 Thread via GitHub
vamossagar12 commented on PR #14882: URL: https://github.com/apache/kafka/pull/14882#issuecomment-1835573531 Looks like this new test failed ``` Error org.opentest4j.AssertionFailedError: expected: but was: Stacktrace org.opentest4j.AssertionFailedError: expected: but

[PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-11-30 Thread via GitHub
vamossagar12 opened a new pull request, #14882: URL: https://github.com/apache/kafka/pull/14882 Adding IT for the case when a static member temporarily leaves the group and another member replaces it. -- This is an automated message from the Apache Git Service. To respond to the message,