Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

soarez merged PR #15832: URL: https://github.com/apache/kafka/pull/15832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

soarez commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2090021412 Thanks for the PR @nizhikov. Thanks for reviewing @chia7712. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

soarez commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1587320225 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1587315800 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1587289081 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

soarez commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1587242657 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1587157698 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2089753995 @chia7712 CI looks OK for me. Do you have any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1586258801 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1586122285 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1585527416 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584953273 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2085538452 @chia7712 All your comments resolved. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584946619 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584811761 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2085194654 @soarez Thanks for the valuable feedback. I create java version of waitUntilTrue method and used it in test. Please, take a look. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584714610 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584629877 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584553620 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2084909110 Hello @chia7712 Can you, please, take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

nizhikov opened a new pull request, #15832: URL: https://github.com/apache/kafka/pull/15832 This is second part of https://github.com/apache/kafka/pull/15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains UserScramCredentialsCommandTest rewritten in