gharris1727 merged PR #15316:
URL: https://github.com/apache/kafka/pull/15316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #15316:
URL: https://github.com/apache/kafka/pull/15316#issuecomment-1981533086
Test failures appear unrelated, and the runtime tests pass locally for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hgeraldino commented on PR #15316:
URL: https://github.com/apache/kafka/pull/15316#issuecomment-1952966858
Thanks @gharris1727 for your review. I think I addressed most of your
comments.
If anyone has any other suggestions, please let me know. Ideally we should
rename this file
hgeraldino commented on code in PR #15316:
URL: https://github.com/apache/kafka/pull/15316#discussion_r1494896646
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -601,6 +690,567 @@ public void
hgeraldino commented on code in PR #15316:
URL: https://github.com/apache/kafka/pull/15316#discussion_r1494861815
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -447,6 +457,85 @@ public void testPollRedelivery() {
hgeraldino commented on code in PR #15316:
URL: https://github.com/apache/kafka/pull/15316#discussion_r1494825277
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -601,6 +690,567 @@ public void
hgeraldino commented on code in PR #15316:
URL: https://github.com/apache/kafka/pull/15316#discussion_r1494816048
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -601,6 +690,567 @@ public void
hgeraldino commented on code in PR #15316:
URL: https://github.com/apache/kafka/pull/15316#discussion_r1494806542
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -601,6 +690,567 @@ public void
hgeraldino commented on PR #15316:
URL: https://github.com/apache/kafka/pull/15316#issuecomment-1940100133
Final batch of the `WorkerSinkTaskTest` migration
This one is probably the largest of the 3 (sorry).
We can either do one final commit renaming the test from
divijvaidya commented on PR #15316:
URL: https://github.com/apache/kafka/pull/15316#issuecomment-1938598989
As part of this last batch, please also removed this test from the list
here:
https://github.com/apache/kafka/blob/5cfcc52fb3fce4a43ca77df311382d7a02a40ed2/build.gradle#L424
--
hgeraldino opened a new pull request, #15316:
URL: https://github.com/apache/kafka/pull/15316
Last batch for migrating WorkerSinkTaskTest tests to Mockito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
11 matches
Mail list logo
