mimaison closed pull request #13860: KAFKA-15093: Add 3.4 and 3.5 Streams
upgrade system tests
URL: https://github.com/apache/kafka/pull/13860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1773771925
@mjsax Good call, I've split this PR in 2:
- 3.4: https://github.com/apache/kafka/pull/14601
- 3.5: https://github.com/apache/kafka/pull/14602
Closing this PR
--
This is
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1773536152
Merged the other PR. Btw: should we split this PR into two, one to add 3.4
and one to add 3.5? So it's easier to cherry-pick? (Adding 3.5 should only go
into `3.6` branch, but adding 3.4
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1767576747
Updated https://github.com/apache/kafka/pull/14539 and re-triggered a system
test run. Let's hope for the best :)
--
This is an automated message from the Apache Git Service.
To respond
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1767572941
Summary about your test results:
- `streams_upgrade_test` expected to still fail because 14539 was not
merged yet
- `streams_cooperative_rebalance_upgrade_test` -- seems to be flaky
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1767260687
> I rebased this PR on trunk
https://github.com/apache/kafka/pull/14539 is not merged yet... So that's
expected I guess. -- We actually also just found another bug that was fixed in
mimaison commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1766096286
I rebased this PR on trunk and rerun the Streams system tests and still got
a bunch of failures:
```
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1760562882
> while it was backported to 3.3 branch, too, we never did a bug fix
release afterwards and thus the system test that pull release binaries only
cannot pickup the cherry-pick
I
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1760532227
I just opened a PR to fix `trunk` -- if this PR is merged, I can cherry-pick
it to older branches, and you can rebase this PR so we can verify everything is
in order and we can merge this
mimaison commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1757751832
Thanks @mjsax for following up. So what's the path forward? Are we able to
merge this or do we need to release new bugfix versions for 3.3 and 3.4 (and
3.5?)?
--
This is an automated
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1748162304
Another issue just introduced in `trunk` ->
https://github.com/apache/kafka/pull/14490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1748136807
I identified one fundamental problem in 3.3 release -- a bug was introduced
that fundamentally breaks KS systems tests using that version. This PR
mimaison commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1744647216
@mjsax These missing tests are starting to pile up. We're already missing
them for 3.4 and 3.5, and 3.6 will be out shortly. If we were to break
compatibility in Streams how would we
13 matches
Mail list logo
