abhijeetk88 commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2141192632
Thanks @chia7712 @jolshan . Apologies for the miss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
junrao commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2140919323
@jolshan : Thanks for pointing this out. Sorry that I didn't look at the
test results carefully before merging.
--
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2140866041
@jolshan I file https://github.com/apache/kafka/pull/16146 to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jolshan commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2140804438
Can we look at testCopyQuotaManagerConfig() –
kafka.log.remote.RemoteLogManagerTest? It seems like it is failing pretty
consistently.
--
This is an automated message from the Apache
junrao merged PR #15625:
URL: https://github.com/apache/kafka/pull/15625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1619973284
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig
junrao commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1619445831
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig {
showuon commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2137244557
@junrao , since this PR blocks other follow-up PRs and v3.8.0 release date
is approaching, I'd like to merge it tomorrow if you don't have any other
comments. Thanks.
--
This is an
abhijeetk88 commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2136524934
> @abhijeetk88 , there is a merge conflict. Please help resolve it. Thanks.
done
> Do we plan to change the default copy quota window num samples from 61 to
11?
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1618186590
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
showuon commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2136406740
@abhijeetk88 , there is a merge conflict. Please help resolve it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kamalcph commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1617015938
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
abhijeetk88 commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2132600646
@showuon @junrao I have addressed your comments. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1613033249
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1612931258
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
showuon commented on PR #15625:
URL: https://github.com/apache/kafka/pull/15625#issuecomment-2126707276
@abhijeetk88 , do we have any update on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1597682003
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -181,7 +189,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1597667627
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1597667613
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1597666914
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1597664809
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig
junrao commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1589688863
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -181,7 +189,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
showuon commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1588939433
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig {
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580557688
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580549399
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580545776
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580515079
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1580499863
##
core/src/test/java/kafka/log/remote/quota/RLMQuotaManagerTest.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
kamalcph commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1577552070
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1576007574
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
Review Comment:
Yes, the integration of the quota manager will come in the follow-up
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1576005665
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
funky-eyes commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1572073595
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
Review Comment:
I have a question, in fact, what this PR does is to provide a standard
HenryCaiHaiying commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1566566286
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
33 matches
Mail list logo
