lucasbru merged PR #14193:
URL: https://github.com/apache/kafka/pull/14193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #14193:
URL: https://github.com/apache/kafka/pull/14193#issuecomment-1776737693
Test failures are unrelated / existing flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1364030636
##
streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java:
##
@@ -676,7 +677,7 @@ public void
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1364028732
##
streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java:
##
@@ -64,6 +64,7 @@
import java.util.LinkedList;
import
cadonna commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1364019538
##
streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java:
##
@@ -64,6 +64,7 @@
import java.util.LinkedList;
import
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1364008408
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -286,6 +295,103 @@ private void
cadonna commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1363559332
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/SynchronizedPartitionGroupTest.java:
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1360190308
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SynchronizedPartitionGroup.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1360189812
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1707,6 +1766,44 @@ void addRecordsToTasks(final ConsumerRecords
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1360187606
##
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java:
##
@@ -361,7 +369,7 @@ private long nextOffset(TopicPartition tp) {
}
public
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1360180889
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SynchronizedPartitionGroup.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1360178932
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractPartitionGroup.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1348755156
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -452,6 +468,31 @@ public static StreamThread create(final
cadonna commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1345894518
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -387,7 +391,9 @@ public static StreamThread create(final
14 matches
Mail list logo
