Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
jolshan merged PR #14480: URL: https://github.com/apache/kafka/pull/14480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
jolshan commented on PR #14480: URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747589664 Tests are unrelated  It is a bit worrying we see this large number of failures in Java 11 from time to time. I may follow up later. -- This is an automated message from the Apache

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
jolshan commented on PR #14480: URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747267286 I will open the kafka-site PR shortly :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
jolshan commented on PR #14480: URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747252798 Filed https://issues.apache.org/jira/browse/KAFKA-15545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
divijvaidya commented on code in PR #14480: URL: https://github.com/apache/kafka/pull/14480#discussion_r1345351170 ## docs/ops.html: ## @@ -1789,6 +1789,16 @@

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
divijvaidya commented on PR #14480: URL: https://github.com/apache/kafka/pull/14480#issuecomment-1746315640 > If we don't already report the AddPartitionsToTxn request metrics in this file, it doesn't make sense to add the verification variant. (As well as all the other APIs we report)

[PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-03 Thread via GitHub
jolshan opened a new pull request, #14480: URL: https://github.com/apache/kafka/pull/14480 I've added details for VerificationFailureRate and VerificationTimeMs. I considered adding the documentation for the AddPartitionsToTxnVerification metrics, but I noticed that all the request