jolshan merged PR #14599:
URL: https://github.com/apache/kafka/pull/14599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1874737282
Thanks @MikeEdgar looks like the test is fixed. I'll run the build again to
make sure there aren't any other related tests failing.
--
This is an automated message from the Apache Git S
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1867795357
Hey @MikeEdgar I'm seeing KafkaAdminClientTest.testDescribeTopicByIds
failing due to it expecting the old error. Can we update that test?
--
This is an automated message from the Apache
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1866730662
Sorry for the delay @MikeEdgar. That is a known issue for the test. I will
also look at this PR and run the build again.
--
This is an automated message from the Apache Git Service.
To
MikeEdgar commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1857793048
@jolshan , I've updated the test and it's passing, but the CI is failing on
a seemingly unrelated test.
```
Gradle Test Run :storage:test > Gradle Test Executor 76 >
Transacti
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1856434562
@MikeEdgar that looks to be right. But please run the test to make sure it
works correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
MikeEdgar commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1852564791
Thanks for the feedback @jolshan . If I'm following your comments on the
broken test, the assertion
```scala
assertThrows(classOf[ExecutionException], () =>
results.get(nonExistin
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1852550819
I synced with @ijuma offline. I think it makes sense to return the
UnknownTopicId exception since that is what we do for the deleteTopics api and
what the server is using.
It is a
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1851104746
At first I was confused since the original PR had
https://github.com/apache/kafka/blob/2a5fbf28820ddcde5ead605e070391059d5d2e18/core/src/test/scala/integration/kafka/api/PlaintextAdminInte
MikeEdgar commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1828509146
Hi @jolshan , please take a look at this PR to modify the exception thrown
when describing a topic by an unknown topic ID. The CI failures don't appear
related to the change.
--
This
MikeEdgar opened a new pull request, #14599:
URL: https://github.com/apache/kafka/pull/14599
Throw `UnknownTopicIdException` instead of `InvalidTopicException` when no
name is found for the topic ID.
Similar to #6124 for `describeTopics` using a topic name. `MockAdminClient`
already
11 matches
Mail list logo
