Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-06-04 Thread via GitHub
github-actions[bot] commented on PR #15472: URL: https://github.com/apache/kafka/pull/15472#issuecomment-2148789357 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-06 Thread via GitHub
divijvaidya commented on code in PR #15472: URL: https://github.com/apache/kafka/pull/15472#discussion_r1514414426 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -202,6 +203,9 @@ public List read() { private final UnifiedLog mockLog =

Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-06 Thread via GitHub
Nickstery commented on code in PR #15472: URL: https://github.com/apache/kafka/pull/15472#discussion_r1514277995 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -707,6 +708,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-06 Thread via GitHub
Nickstery commented on code in PR #15472: URL: https://github.com/apache/kafka/pull/15472#discussion_r1514277995 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -707,6 +708,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-06 Thread via GitHub
Nickstery commented on code in PR #15472: URL: https://github.com/apache/kafka/pull/15472#discussion_r1514266315 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -75,13 +75,14 @@ public void sanityCheck() { TimestampOffset entry =

Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-05 Thread via GitHub
divijvaidya commented on code in PR #15472: URL: https://github.com/apache/kafka/pull/15472#discussion_r1513268220 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -707,6 +708,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws

[PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-05 Thread via GitHub
Nickstery opened a new pull request, #15472: URL: https://github.com/apache/kafka/pull/15472 During index corruption we have to perform sanity checks for tiering segment to remote -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-05 Thread via GitHub
Nickstery closed pull request #15471: KAFKA-15401 | Segment with corrupted index should not be tiered URL: https://github.com/apache/kafka/pull/15471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-15401 | Segment with corrupted index should not be tiered [kafka]

2024-03-05 Thread via GitHub
Nickstery opened a new pull request, #15471: URL: https://github.com/apache/kafka/pull/15471 During index corruption we have to perform sanity checks for tiering segment to remote -- This is an automated message from the Apache Git Service. To respond to the message, please log on to