github-actions[bot] commented on PR #14491:
URL: https://github.com/apache/kafka/pull/14491#issuecomment-1888380144
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #14504:
URL: https://github.com/apache/kafka/pull/14504#issuecomment-1882343351
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
rbaddam commented on PR #14491:
URL: https://github.com/apache/kafka/pull/14491#issuecomment-1762132178
Thank you @omkreddy for the review and feedback.
I have updated the
[KIP-982](https://cwiki.apache.org/confluence/display/KAFKA/KIP-982%3A+Access+SslPrincipalMapper+and+kerberosShor
omkreddy commented on PR #14491:
URL: https://github.com/apache/kafka/pull/14491#issuecomment-1762024387
@rbaddam Thanks for the PR. Can you please update the KIP with newly added
interfaces also. I will review the PR once KIP passes.
--
This is an automated message from the Apache Git S
rbaddam commented on PR #14491:
URL: https://github.com/apache/kafka/pull/14491#issuecomment-1761825493
Also we have implemented the SPIFFE Integration in our echo system and
[these changes](https://github.com/apache/kafka/pull/14491) will help to make
the Spiffe Integration smooth.
rbaddam commented on PR #14491:
URL: https://github.com/apache/kafka/pull/14491#issuecomment-1758769891
Hi @mjsax, @jlprat, @satishd, @jolshan, @raboof, @dajac, Would any of you be
available to review this new PR I raised?
Your insights and suggestions would be very helpful.
T
plazma-prizma commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1353388791
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilde
rbaddam commented on PR #14504:
URL: https://github.com/apache/kafka/pull/14504#issuecomment-1755866839
To address your concern about the specificity of the solution, I will create
Interfaces/subclasses of KerberosPrincipalBuilder and SSLPrincipalBuilder to
handle different types of princip
rbaddam commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350996498
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilder(Map
rbaddam commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350920227
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilder(Map
rbaddam commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350588084
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilder(Map
plazma-prizma commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350253419
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilde
rbaddam opened a new pull request, #14504:
URL: https://github.com/apache/kafka/pull/14504
Made the changes to allow custom KafkaPrincipalBuilder implementations to
access SslPrincipalMapper and kerberosShortNamer so that custom
KafkaPrincipalBuilders will be able to parse Regex Rules from
rbaddam commented on PR #14491:
URL: https://github.com/apache/kafka/pull/14491#issuecomment-1749347191
@mimaison @divijvaidya Could you please review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rbaddam opened a new pull request, #14491:
URL: https://github.com/apache/kafka/pull/14491
Made the changes to allow custom KafkaPrincipalBuilder implementations to
access SslPrincipalMapper and kerberosShortNamer so that custom
KafkaPrincipalBuilders will be able to parse Regex Rules from
15 matches
Mail list logo
