Re: [PR] KAFKA-15527: Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore and update upgrade-guide.html for kafka streams webpage [kafka]

2023-10-26 Thread via GitHub
mjsax merged PR #14600: URL: https://github.com/apache/kafka/pull/14600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15527: Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore and update upgrade-guide.html for kafka streams webpage [kafka]

2023-10-20 Thread via GitHub
hanyuzheng7 commented on code in PR #14600: URL: https://github.com/apache/kafka/pull/14600#discussion_r1367661864 ## docs/streams/upgrade-guide.html: ## @@ -133,6 +133,15 @@ < More details about the new config StreamsConfig#TOPOLOGY_OPTIMIZATION can be found in https:

Re: [PR] KAFKA-15527: Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore and update upgrade-guide.html for kafka streams webpage [kafka]

2023-10-20 Thread via GitHub
hanyuzheng7 commented on code in PR #14600: URL: https://github.com/apache/kafka/pull/14600#discussion_r1367619716 ## streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java: ## @@ -48,13 +48,13 @@ public interface ReadOnlyKeyValueStore { * Get an i

Re: [PR] KAFKA-15527: Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore and update upgrade-guide.html for kafka streams webpage [kafka]

2023-10-20 Thread via GitHub
hanyuzheng7 commented on PR #14600: URL: https://github.com/apache/kafka/pull/14600#issuecomment-1773625949 > I think we should also improve `RangeQuery` JavaDocs in addition, to be clear about ordering guarantees there, too. ok -- This is an automated message from the Apache Git S

Re: [PR] KAFKA-15527: Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore and update upgrade-guide.html for kafka streams webpage [kafka]

2023-10-20 Thread via GitHub
mjsax commented on code in PR #14600: URL: https://github.com/apache/kafka/pull/14600#discussion_r1367568404 ## docs/streams/upgrade-guide.html: ## @@ -133,6 +133,15 @@ < More details about the new config StreamsConfig#TOPOLOGY_OPTIMIZATION can be found in https://cwik

[PR] KAFKA-15527: Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore and update upgrade-guide.html for kafka streams webpage [kafka]

2023-10-20 Thread via GitHub
hanyuzheng7 opened a new pull request, #14600: URL: https://github.com/apache/kafka/pull/14600 Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore. Update upgrade-guide.html for kafka streams webpage. ### Committer Checklist (excluded from commit message) - [ ] Ver