Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-11-12 Thread via GitHub
jolshan commented on PR #14506: URL: https://github.com/apache/kafka/pull/14506#issuecomment-1807174506 Thanks @showuon for taking a look. Makes sense to me. I also saw the conversation here. https://github.com/apache/kafka/pull/14741 -- This is an automated message from the Apache

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-11-10 Thread via GitHub
showuon commented on PR #14506: URL: https://github.com/apache/kafka/pull/14506#issuecomment-1805278003 @jolshan , I just created a [PR](https://github.com/apache/kafka/pull/14730) to revert the change in this PR, and the test results also failed `testSingleIP` test. So, let's keep

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-11-09 Thread via GitHub
showuon commented on PR #14506: URL: https://github.com/apache/kafka/pull/14506#issuecomment-1805023823 I had a look, and think this flaky test should be the infra's issue, not our code. Like you said, in 3.6 branch, after I backported this PR, it started to fail (on Nov. 9). Now, checking

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-11-09 Thread via GitHub
jolshan commented on PR #14506: URL: https://github.com/apache/kafka/pull/14506#issuecomment-1804803577 Hey I was taking a look at 3.6 builds and it looks like

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-11-09 Thread via GitHub
showuon commented on PR #14506: URL: https://github.com/apache/kafka/pull/14506#issuecomment-1803521941 Backported to 3.5 and 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-10-05 Thread via GitHub
cmccabe merged PR #14506: URL: https://github.com/apache/kafka/pull/14506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-10-05 Thread via GitHub
mumrah opened a new pull request, #14506: URL: https://github.com/apache/kafka/pull/14506 This patch fixes a problem where we migrate the current producer ID batch to KRaft instead of the next producer ID batch. Since KRaft stores the _next_ batch in the log, we end up serving up a