Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1772643223 Hi @divijvaidya. Thanks for pointing that out, I will take a look. I assigned ticket to myself. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

divijvaidya commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1772557774 Hi @lkokhreidze - the test added in the PR `shouldInvokeUserDefinedGlobalStateRestoreListener` has been flaky since it was added. You can find the flaky build on trunk using the link

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1759069004 Thanks Sophie. I will do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

ableegoldman commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1759052065 I would personally love to see a 3.5.2 release, but having managed both a bugfix release myself in the past, I can attest that it's not a trivial amount of work. Usually we don't do

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1758991030 Many thanks @ableegoldman for merging the PR 🙇 What do you think about 3.5.2 release with a fix? I'm no expert with the Kafka release processes, but given the feature was implem

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

ableegoldman commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1758665862 Merged to trunk and will backport to 3.6 and 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-15571: `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

ableegoldman merged PR #14519: URL: https://github.com/apache/kafka/pull/14519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

ableegoldman commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1758663469 By the way, make sure to format the PR titles exactly as recommended -- there are some integrations that regex match and rely on this (you had a slash `/` instead of a colon `:`)

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on code in PR #14519: URL: https://github.com/apache/kafka/pull/14519#discussion_r1354484003 ## streams/src/test/java/org/apache/kafka/streams/integration/StateRestoreListerIntegrationTest.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software F

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on code in PR #14519: URL: https://github.com/apache/kafka/pull/14519#discussion_r1354282349 ## streams/src/test/java/org/apache/kafka/streams/integration/StateRestoreListerIntegrationTest.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software F

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

ableegoldman commented on code in PR #14519: URL: https://github.com/apache/kafka/pull/14519#discussion_r1354281780 ## streams/src/test/java/org/apache/kafka/streams/integration/StateRestoreListerIntegrationTest.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1756120126 Hi @cadonna, I've added an integration test. It seemed the safest way to test out the new functionality. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1755442563 Thanks @cadonna I will continue working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t