Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

mumrah merged PR #14706: URL: https://github.com/apache/kafka/pull/14706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on PR #14706: URL: https://github.com/apache/kafka/pull/14706#issuecomment-2005099068 The test failures are irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

mumrah commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1526384089 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1369,7 +1384,23 @@ void handleBrokerInControlledShutdown(int brokerId, long

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1520116151 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1837,8 +1872,13 @@ void generateLeaderAndIsrUpdates(String

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115442 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2240,6 +2283,25 @@ private void updatePartitionDirectories(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115750 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -336,10 +350,10 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

mumrah commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1519830343 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2240,6 +2283,25 @@ private void updatePartitionDirectories( }

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1489894351 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -336,10 +342,14 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1489894070 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -780,4 +789,9 @@ public Entry> next() { } };

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

mumrah commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1489685922 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1408490077 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -466,6 +466,10 @@ private void

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

artemlivshits commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1401454282 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -528,6 +536,10 @@ private void maybePopulateTargetElr() {

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1400042116 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1400041537 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -327,10 +333,12 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1400041854 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1772,7 +1814,8 @@ void generateLeaderAndIsrUpdates(String context,

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1400041780 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1400036881 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -466,6 +466,10 @@ private void

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

artemlivshits commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1399798771 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -466,6 +466,10 @@ private void

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1399579994 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -327,10 +333,12 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1399575912 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1294,8 +1315,11 @@ void handleBrokerFenced(int brokerId, List

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

mumrah commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1399468190 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -327,10 +333,12 @@ public ControllerResult registerBroker( ",

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1384373047 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under