Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-20 Thread via GitHub
C0urante merged PR #14587: URL: https://github.com/apache/kafka/pull/14587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-20 Thread via GitHub
C0urante commented on PR #14587: URL: https://github.com/apache/kafka/pull/14587#issuecomment-1773026960 Makes sense, thanks for the explanation @hudeqi! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-19 Thread via GitHub
hudeqi commented on code in PR #14587: URL: https://github.com/apache/kafka/pull/14587#discussion_r1366378637 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointTaskTest.java: ## @@ -169,6 +169,33 @@ public void testSyncOffset() { "C

Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-19 Thread via GitHub
hudeqi commented on PR #14587: URL: https://github.com/apache/kafka/pull/14587#issuecomment-1771985878 > Thanks @hudeqi, I think this is reasonable. Do you know why Sarama sets offsets to -1? If it's for normal operations and not indicative of something wrong, we may not even need to log a

Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-19 Thread via GitHub
C0urante commented on PR #14587: URL: https://github.com/apache/kafka/pull/14587#issuecomment-1771748040 Thanks @hudeqi, I think this is reasonable. Do you know why Sarama sets offsets to -1? If it's for normal operations and not indicative of something wrong, we may not even need to log a

Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-19 Thread via GitHub
C0urante commented on code in PR #14587: URL: https://github.com/apache/kafka/pull/14587#discussion_r1366159693 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointTaskTest.java: ## @@ -169,6 +169,33 @@ public void testSyncOffset() {

Re: [PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-19 Thread via GitHub
hudeqi commented on PR #14587: URL: https://github.com/apache/kafka/pull/14587#issuecomment-1770925618 Hi, @clolov. Excuse me, can you help me trigger the build for this PR? I'm also collaborator, why can't I find a place to trigger build PR :) -- This is an automated message from the Apa

[PR] KAFKA-15607:Possible NPE is thrown in MirrorCheckpointTask [kafka]

2023-10-19 Thread via GitHub
hudeqi opened a new pull request, #14587: URL: https://github.com/apache/kafka/pull/14587 In the `syncGroupOffset` method, if `targetConsumerOffset.get(topicPartition)` gets null, then the calculation of `latestDownstreamOffset` will throw NPE. This usually occurs in this situation: a grou