mjsax merged PR #14566:
URL: https://github.com/apache/kafka/pull/14566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #14566:
URL: https://github.com/apache/kafka/pull/14566#issuecomment-1769879629
Again a lot of flaky test noise:
```
Build / JDK 11 and Scala 2.13 /
testFollowerCompleteDelayedFetchesOnReplication(String).quorum=kraft –
mjsax commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364865721
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetryState.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mjsax commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364857199
##
clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation
mjsax commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364856191
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364855062
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on PR #14566:
URL: https://github.com/apache/kafka/pull/14566#issuecomment-1769489693
Thanks @wcarlson5 and @kirktrue for approving.
I see build fails because of below error which I see on other PRs as well,
can I fix that or else how we can merge the PR?
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364615810
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetryState.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364609421
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kirktrue commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364364114
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kirktrue commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364360520
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kirktrue commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364347784
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetryState.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on PR #14566:
URL: https://github.com/apache/kafka/pull/14566#issuecomment-1767932760
> Hi @apoorvmittal10 - Thanks for the PR. I left two comments, similar to
@mjsax 's:
>
> 1. It seems like internal package is a good place for the state machine
> 2.
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363452039
##
clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363451545
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
AndrewJSchofield commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363449466
##
clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on PR #14566:
URL: https://github.com/apache/kafka/pull/14566#issuecomment-1767581183
Hi @apoorvmittal10 - Thanks for the PR. I left two comments, similar to
@mjsax 's:
1. It seems like internal package is a good place for the state machine
2. IllegalStateException
philipnee commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363114377
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363112509
##
clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363095438
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363095438
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1363092161
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362871568
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362858382
##
clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362852365
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mjsax commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362827605
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362714998
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362709895
##
clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362708196
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
AndrewJSchofield commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1362631340
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 opened a new pull request, #14566:
URL: https://github.com/apache/kafka/pull/14566
PR for
[KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability)
- [KAFKA-15616](https://issues.apache.org/jira/browse/KAFKA-15616).
This
31 matches
Mail list logo
