Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan merged PR #14568: URL: https://github.com/apache/kafka/pull/14568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on PR #14568: URL: https://github.com/apache/kafka/pull/14568#issuecomment-1773413391 Test failures look unrelated. Will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365978462 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365978462 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365968314 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365915582 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365914738 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365908991 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365876383 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365595431 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1365594250 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364857293 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364857293 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364343631 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364343631 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364207881 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364172007 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.t

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364117639 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364117639 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1364107748 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.t

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1363846193 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1363844237 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1363844237 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1363844237 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.toL

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

ijuma commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1363840779 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

artemlivshits commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1362959888 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completed

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1362938647 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completedTxns.t

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

artemlivshits commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1362920242 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers, completed

[PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan opened a new pull request, #14568: URL: https://github.com/apache/kafka/pull/14568 I've added a new class with an incrementing atomic long to represent the verification guard. Upon creation of verification guard, we will increment this value and assign it to the guard. The e