msn-tldr commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1379946778
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,92 @@ public synchronized void update(int requestVersion,
MetadataResponse response
msn-tldr commented on PR #14685:
URL: https://github.com/apache/kafka/pull/14685#issuecomment-1790463567
@wcarlson5 thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wcarlson5 merged PR #14685:
URL: https://github.com/apache/kafka/pull/14685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
wcarlson5 commented on PR #14685:
URL: https://github.com/apache/kafka/pull/14685#issuecomment-1789576997
I'm satisfied with comments and discussion on old PR
https://github.com/apache/kafka/pull/14564 so I'm going to go a head and merge
this
--
This is an automated message from the Apac
wcarlson5 commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1379261920
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,92 @@ public synchronized void update(int requestVersion,
MetadataResponse respons
msn-tldr commented on PR #14685:
URL: https://github.com/apache/kafka/pull/14685#issuecomment-1789309939
So the CI failures are flaky, unrelated tests.
https://ge.apache.org/s/t6qcbarr56fe2/tests/overview?outcome=FLAKY,FAILED
https://ge.apache.org/s/a7bylhq5x4jnc/tests/overview?outcome=
msn-tldr commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1378976609
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -186,6 +193,15 @@ protected void handleFetchSuccess(final Node fetchTarg
ex172000 commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1378796519
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -186,6 +193,15 @@ protected void handleFetchSuccess(final Node fetchTarg
ex172000 commented on code in PR #14685:
URL: https://github.com/apache/kafka/pull/14685#discussion_r1378794965
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,92 @@ public synchronized void update(int requestVersion,
MetadataResponse response
msn-tldr opened a new pull request, #14685:
URL: https://github.com/apache/kafka/pull/14685
This implements the leader discovery optimisations for the client on
[KIP-951](https://cwiki.apache.org/confluence/display/KAFKA/KIP-951%3A+Leader+discovery+optimisations+for+the+client).
Optim
msn-tldr commented on PR #14564:
URL: https://github.com/apache/kafka/pull/14564#issuecomment-1788826662
Rebasing my fork seems to have removed the PR commits from the remote branch
`kip951_client_changes`, that has *automatically* closed this PR 😞
Something to be careful of in future, t
msn-tldr closed pull request #14564: KAFKA-15627: KIP-951's Leader discovery
optimisations on the client
URL: https://github.com/apache/kafka/pull/14564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1378662641
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -198,6 +215,20 @@ protected void handleFetchSuccess(final Node fetchTarg
wcarlson5 commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1378153127
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,91 @@ public synchronized void update(int requestVersion,
MetadataResponse respons
msn-tldr commented on PR #14564:
URL: https://github.com/apache/kafka/pull/14564#issuecomment-1779551983
@AndrewJSchofield & @kirktrue addressed the feedback so far!
thanks for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1371479753
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -614,13 +618,28 @@ private void handleProduceResponse(ClientResponse
response,
AndrewJSchofield commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1371441595
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -685,6 +711,13 @@ private void completeBatch(ProducerBatch batch,
Prod
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370368421
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -150,7 +150,7 @@ MetadataCache mergeWith(String newClusterId,
// We want the most
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370368421
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -150,7 +150,7 @@ MetadataCache mergeWith(String newClusterId,
// We want the most
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370368421
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -150,7 +150,7 @@ MetadataCache mergeWith(String newClusterId,
// We want the most
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370368421
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -150,7 +150,7 @@ MetadataCache mergeWith(String newClusterId,
// We want the most
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370531714
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -171,6 +179,15 @@ protected void handleFetchResponse(final Node fetchTar
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370531714
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -171,6 +179,15 @@ protected void handleFetchResponse(final Node fetchTar
msn-tldr commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1370368421
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -150,7 +150,7 @@ MetadataCache mergeWith(String newClusterId,
// We want the most
24 matches
Mail list logo
