ijuma commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1983994964
Great, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1983853541
@ijuma scala code removed in
https://github.com/apache/kafka/commit/76b1b50b644149e77ee1ec42d882e2cb80742bdf#diff-48cfe3a3a1343f9583c6a3c74602deacfdbac3fc49d5570599b1dd821a0ae742
--
Th
ijuma commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1983724313
Thanks for the PR. Quick question, how come we didn't delete the Scala code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1840593068
Thanks all for review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
mimaison merged PR #14588:
URL: https://github.com/apache/kafka/pull/14588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1832765723
Hello @jolshan are you ready to merge this?
Can I improve this PR somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mimaison commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1827997491
@jolshan Do you have further comments? I triggered a rebuild
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14588/18/pipeline/
and it seems fine.
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1823869599
Hello @mimaison
Are you be able to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1814225513
Hello @jolshan . Should I improve this PR somehow to finish it?
@mimaison Do you have any feedback?
--
This is an automated message from the Apache Git Service.
To respond to the mes
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1808206878
Hello @jolshan, are you ready to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1805320880
Now only 24 tests failed.
And the all seems not related to the tool.
@mimaison do you have more comments to the PR?
Can we merge it?
--
This is an automated message from th
jolshan commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1804276008
Looks pretty good generally.
CI has quite a few failures. They seem unrelated and I will follow up. I
restarted the job.
I will also wait a bit if @mimaison has any more comments
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1388355756
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1803900030
CI seems OK. Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387612584
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387606436
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387604144
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387311881
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387309744
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387308586
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,479 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387305189
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387236588
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
I remov
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386974229
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Without
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386970135
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386961908
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386961908
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386960816
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386957752
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
+1
--
mimaison commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386949236
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Do we r
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1802193860
Hello, @mimaison @jolshan
Can, you, please, take a look?
I think we have to merge PR to don't lost test utility.
--
This is an automated message from the Apache Git Service.
To
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1788570036
@mimaison @jolshan Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1788569671
I update this PR with trunk and rerun utility locally with java version of
`PartitionReassignCommand`. The results still very similary to previous runs:
 under o
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1366966675
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,480 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
tledkov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1366961579
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,480 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1366955360
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,480 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
tledkov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1366947495
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,480 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1770871042
@benstopford @ewencp As authors of scala version of
`ReplicationQuotasTestRig` can you, please, take a look at this PR?
It rewrites `ReplicationQuotasTestRig` from scala to java.
--
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1770683947
Hello, @mimaison @jolshan
This PR is very last dependency of `ReassignPartitionsCommand` rewritten in
java.
Please, take a look.
--
This is an automated message from the Apa
nizhikov opened a new pull request, #14588:
URL: https://github.com/apache/kafka/pull/14588
This is part of #13247
It rewrites `ReplicationQuotasTestRig` from scala to java.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] V
48 matches
Mail list logo
