Re: [PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-23 Thread via GitHub
mimaison commented on PR #14601: URL: https://github.com/apache/kafka/pull/14601#issuecomment-1775449629 Ah ok, thanks for clarifying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-23 Thread via GitHub
mjsax commented on PR #14601: URL: https://github.com/apache/kafka/pull/14601#issuecomment-1775440767 We don't need to backported to `3.4` branch -- In `3.4` branch we test this implicitly by upgrading to `DEV_VERSION`. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-23 Thread via GitHub
mimaison commented on PR #14601: URL: https://github.com/apache/kafka/pull/14601#issuecomment-1774770251 Backported to 3.5 Running the system tests on 3.4, then I'll backport to 3.4 too -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-23 Thread via GitHub
mimaison commented on PR #14601: URL: https://github.com/apache/kafka/pull/14601#issuecomment-1774689200 When I ran the Streams system tests in our CI I used this branch, so merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-23 Thread via GitHub
mimaison merged PR #14601: URL: https://github.com/apache/kafka/pull/14601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-22 Thread via GitHub
mimaison commented on PR #14601: URL: https://github.com/apache/kafka/pull/14601#issuecomment-1774154602 @mjsax It looks much better now. I ran the Streams system tests with this PR and just got a few flaky failures. All tests passed at least once in "only" 2 runs. -- This is an

[PR] KAFKA-15664: Add 3.4 Streams upgrade system tests [kafka]

2023-10-21 Thread via GitHub
mimaison opened a new pull request, #14601: URL: https://github.com/apache/kafka/pull/14601 Extracted the 3.4 changes from https://github.com/apache/kafka/pull/13860 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test