junrao merged PR #14933:
URL: https://github.com/apache/kafka/pull/14933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1843520738
> @apoorvmittal10 : Thanks for the updated PR. Just a minor comment.
@junrao Thanks for again reviewing the PR. I have added thoughts for the
comment and verified same locall
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1417826343
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def shou
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1417807074
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def shou
junrao commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1417759706
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def shouldNotDes
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1843269344
@junrao Build passed with unrelated flaky tests failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1842077768
@junrao Thanks for reviewing the PR, I have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1416635870
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6922,4 +6923,58 @@ class KafkaApisTest {
val expectedResponse = new
PushTelemetryRespo
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1416644082
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3810,16 +3811,27 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- // Just a pl
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1416642552
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3810,16 +3811,27 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- // Just a pl
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1416635870
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6922,4 +6923,58 @@ class KafkaApisTest {
val expectedResponse = new
PushTelemetryRespo
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1416631582
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def shou
junrao commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1416359770
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3810,16 +3811,27 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- // Just a placeholde
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1841542850
@junrao @AndrewJSchofield Please if I can get the review on the Minor PR for
the improvement of KIP-714 by using functionality exposed by KIP-1000. Also
added support for listing r
apoorvmittal10 opened a new pull request, #14933:
URL: https://github.com/apache/kafka/pull/14933
PR includes:
- Improvement for KIP-1000 to list client metrics resources in
KafkaApis.scala.
- Using functionality exposed by KIP-1000 to support describe all metrics
operations for KIP-7
15 matches
Mail list logo
