philipnee commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1843868318
Thanks @lucasbru and @kirktrue - i'm closing this one and reopening another
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
philipnee closed pull request #14920: KAFKA-15696: Refactor AsyncConsumer close
procedure
URL: https://github.com/apache/kafka/pull/14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
philipnee commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417647914
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
sw
philipnee commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417647206
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
sw
lucasbru commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417523313
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerTestBuilder.java:
##
@@ -331,34 +331,35 @@ public
AsyncKafkaConsumerTestBuilder(Optional
lucasbru commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1417484146
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
swa
philipnee commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1842376289
@kirktrue - Thanks for reviewing the code. I did some refactor on a
separated branch, I hope this is inline with what you meant there:
https://github.com/apache/kafka/pull/14937 cc @lu
philipnee commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1416732684
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
sw
kirktrue commented on code in PR #14920:
URL: https://github.com/apache/kafka/pull/14920#discussion_r1416404354
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -957,6 +966,57 @@ private void close(Duration timeout, boolean
swa
