Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-06 Thread via GitHub
mimaison commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1929267278 Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-05 Thread via GitHub
appchemist commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1928134072 Thanks for the review! @mimaison Yes, I have About my jira account, Username and Fullname are appchemist. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-05 Thread via GitHub
mimaison commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1927320927 Thanks for the contribution! Do you have a Jira account? If so I can assign https://issues.apache.org/jira/browse/KAFKA-15717 to you. -- This is an automated message from the

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-05 Thread via GitHub
mimaison merged PR #15225: URL: https://github.com/apache/kafka/pull/15225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-04 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-04 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-02 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-02 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948401 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -559,6 +559,31 @@ object TestUtils extends Logging { controllers.foreach(controller =>

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-02 Thread via GitHub
mimaison commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476307322 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -559,6 +559,31 @@ object TestUtils extends Logging { controllers.foreach(controller =>

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-01-26 Thread via GitHub
appchemist commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1911631296 @benstopford Please if you can review and provide the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and