tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1916691435
Thank you @jlprat for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jlprat commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1916625862
Fix is here: https://github.com/apache/kafka/pull/15290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jlprat commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1916610169
Hi @tinaselenge and @dengziming
I think this change broke the build. Right now Kafka can't be compiled with
Scala 2.12, see the error here:
https://ci-builds.apache.org/blue/organizatio
dengziming merged PR #14846:
URL: https://github.com/apache/kafka/pull/14846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1893497699
@dengziming thank you again for reviewing the code. I addressed your
comments, please let me know if I missed anything or have any further comments.
--
This is an automated message
tinaselenge commented on code in PR #14846:
URL: https://github.com/apache/kafka/pull/14846#discussion_r1453250983
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -354,39 +433,54 @@ class DeleteTopicTest extends QuorumTestHarness {
server.logManager.clea
dengziming commented on code in PR #14846:
URL: https://github.com/apache/kafka/pull/14846#discussion_r1448306793
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -425,8 +539,10 @@ class DeleteTopicTest extends QuorumTestHarness {
*/
val replica
tinaselenge commented on code in PR #14846:
URL: https://github.com/apache/kafka/pull/14846#discussion_r1441637951
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -187,164 +197,233 @@ class DeleteTopicTest extends QuorumTestHarness {
}.toSet
}
- @
dengziming commented on code in PR #14846:
URL: https://github.com/apache/kafka/pull/14846#discussion_r1440196006
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -187,164 +197,233 @@ class DeleteTopicTest extends QuorumTestHarness {
}.toSet
}
- @T
dengziming commented on code in PR #14846:
URL: https://github.com/apache/kafka/pull/14846#discussion_r1440196006
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -187,164 +197,233 @@ class DeleteTopicTest extends QuorumTestHarness {
}.toSet
}
- @T
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1867865063
@dengziming I have triggered the build 3 more times and DeleteTopicTest
passed. I have also enabled KRaft for
testIncreasePartitionCountDuringDeleteTopic (they didn't have much common
dengziming commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1860310729
Hello @tinaselenge thanks for the update, here are some of my suggestions:
1. If some controllerContext stuff is required, such as
`testIncreasePartitionCountDuringDeleteTopic`, it's
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1853763567
@dengziming I believe I fixed the flaky tests which did not appear to be
failing in any of the recent builds. The builds still failed but due to the non
related tests.
--
This is
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1842367014
Thanks @dengziming. I will investigate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dengziming commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1841979753
Hello @tinaselenge , there are some flaky related to this, we should take
some time to investigate it, and we should trigger the CI more times to ensure
less flaky.
https://ci-
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1829653182
Hi @dengziming , can you please take a look at this PR whenever you have
time? There are a few test cases that I couldn't run in KRaft mode. They
require replica states from controlle
tinaselenge opened a new pull request, #14846:
URL: https://github.com/apache/kafka/pull/14846
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
17 matches
Mail list logo
