divijvaidya merged PR #14771:
URL: https://github.com/apache/kafka/pull/14771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
divijvaidya commented on PR #14771:
URL: https://github.com/apache/kafka/pull/14771#issuecomment-1875169735
The test modified in this PR is successful -
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14771/4/testReport/org.apache.kafka.trogdor.agent/
--
This is an automated me
gharris1727 commented on PR #14771:
URL: https://github.com/apache/kafka/pull/14771#issuecomment-1874318692
@divijvaidya Thanks for the review. I applied your suggestion. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
divijvaidya commented on PR #14771:
URL: https://github.com/apache/kafka/pull/14771#issuecomment-1872976863
All tests in this test create an `Agent`. We should close them in
`@afterTest` similar to https://github.com/apache/kafka/pull/15091 It's more
robust as it enforces a clean close even
gharris1727 opened a new pull request, #14771:
URL: https://github.com/apache/kafka/pull/14771
The AgentTest leaks the agent under test due to typos. Follow the existing
style in the test to stop it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and imp
