Re: [PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-21 Thread via GitHub
kirktrue commented on PR #14773: URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821397271 > Done! I think this PR can be closed, because it was superseded by #14810 Yes, I will close it with this very comment  -- This is an automated message from the Apache Git

Re: [PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-21 Thread via GitHub
kirktrue closed pull request #14773: KAFKA-15837: Throw error on use of Consumer.poll(long timeout) URL: https://github.com/apache/kafka/pull/14773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-21 Thread via GitHub
cadonna commented on PR #14773: URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821394688 Done! I think this PR can be closed, because it was superseded by https://github.com/apache/kafka/pull/14810 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-21 Thread via GitHub
kirktrue commented on PR #14773: URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821391050 @lucasbru / @cadonna—can we add the `ctr` label for posterity? Then I'll close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-21 Thread via GitHub
AndrewJSchofield commented on PR #14773: URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821132824 This PR has been superseded and can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-16 Thread via GitHub
AndrewJSchofield commented on code in PR #14773: URL: https://github.com/apache/kafka/pull/14773#discussion_r1395324636 ## clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java: ## @@ -78,10 +79,14 @@ public interface Consumer extends Closeable { void

[PR] KAFKA-15837: Throw error on use of Consumer.poll(long timeout) [kafka]

2023-11-15 Thread via GitHub
kirktrue opened a new pull request, #14773: URL: https://github.com/apache/kafka/pull/14773 Per KIP-266, the `Consumer.poll(long timeout)` method was deprecated in 2.0.0. The default implementation of `Consumer.poll(long timeout)` now throws a `KafkaException`, and the known