chia7712 merged PR #15774:
URL: https://github.com/apache/kafka/pull/15774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15774:
URL: https://github.com/apache/kafka/pull/15774#issuecomment-2074035809
```
./gradlew cleanTest :streams:test --tests
EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore
:tools:test --tests
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576308464
##
checkstyle/import-control-metadata.xml:
##
@@ -123,6 +123,7 @@
+
Review Comment:
Fixed
--
This is an automated message
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576308101
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -98,23 +99,18 @@ public class ReassignPartitionsCommand {
static
mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576247775
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -98,23 +99,18 @@ public class ReassignPartitionsCommand {
static
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576188830
##
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfigs.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576158733
##
core/src/main/scala/kafka/server/DynamicConfig.scala:
##
@@ -36,30 +35,12 @@ import scala.jdk.CollectionConverters._
object DynamicConfig {
Review Comment:
It
chia7712 commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1575855253
##
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfigs.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574929931
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574769505
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574750038
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574744528
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574733563
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574732048
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574731972
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1574685410
##
server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
OmniaGM opened a new pull request, #15774:
URL: https://github.com/apache/kafka/pull/15774
- Pull all quota configs from `KafkaConfig`, `DynamicConfig` and `LogConfig`
into `ServerQuotaConfigs` in `server-commons` as replication configs are shared
between server, storage and tools
17 matches
Mail list logo
