cmccabe merged PR #14899:
URL: https://github.com/apache/kafka/pull/14899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on PR #14899:
URL: https://github.com/apache/kafka/pull/14899#issuecomment-1844406974
Jenkins had an internal issue. Re-pushing to get a clean build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
soarez commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1413167592
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,55 @@ public MetadataShell build() {
}
}
+/**
+ * Return the gr
cmccabe commented on PR #14899:
URL: https://github.com/apache/kafka/pull/14899#issuecomment-1836970040
In addition to the junit tests, I also tested this manually and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412689568
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -119,6 +141,7 @@ private void initializeWithRaftManager() {
}
private void initializ
cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412672706
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+static FileLock takeFile
cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412672706
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+static FileLock takeFile
jsancio commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412657561
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+static FileLock takeFile
cmccabe opened a new pull request, #14899:
URL: https://github.com/apache/kafka/pull/14899
MetadataShell should take an advisory lock on the .lock file of the
directory it is reading from. Add an integration test of this functionality in
MetadataShellIntegrationTest.java.
Note: in bu
