Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-22 Thread via GitHub
lucasbru commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1499319626 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-21 Thread via GitHub
mjsax commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1498439703 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-19 Thread via GitHub
lucasbru merged PR #15383: URL: https://github.com/apache/kafka/pull/15383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-16 Thread via GitHub
lucasbru commented on PR #15383: URL: https://github.com/apache/kafka/pull/15383#issuecomment-1948876369 Hey @mjsax . This PR is right now waiting for @cadonna's review. If you have time, you could take a look to get into the 848 work. -- This is an automated message from the Apache Git S

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-16 Thread via GitHub
lucasbru commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1492621621 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-16 Thread via GitHub
lianetm commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1492613876 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-16 Thread via GitHub
lucasbru commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1492547506 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -384,7 +387,7 @@ public void testWakeupAfterEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-16 Thread via GitHub
lucasbru commented on PR #15383: URL: https://github.com/apache/kafka/pull/15383#issuecomment-1948483411 @cadonna Could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-16 Thread via GitHub
lucasbru opened a new pull request, #15383: URL: https://github.com/apache/kafka/pull/15383 The wake-up mechanism in the new consumer is preventing from committing within a rebalance listener callback. The reason is that we are trying to register two wake-uppable actions at the same time.