Re: [PR] KAFKA-16013: Added integration test for ExpiresPerSec metric [kafka]

2023-12-19 Thread via GitHub
satishd commented on PR #15015: URL: https://github.com/apache/kafka/pull/15015#issuecomment-1862357833 @showuon Please take a look at the `ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric` failure in the Jenkins jobs. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16013: Added integration test for ExpiresPerSec metric [kafka]

2023-12-18 Thread via GitHub
showuon commented on PR #15015: URL: https://github.com/apache/kafka/pull/15015#issuecomment-1862142091 > @showuon Some of the existing tests in `DelayedRemoteFetchTest` are failing as the followerFetchParams are passed with a valid replicaId. I took liberty of fixing the existing tests in

Re: [PR] KAFKA-16013: Added integration test for ExpiresPerSec metric [kafka]

2023-12-18 Thread via GitHub
satishd commented on PR #15015: URL: https://github.com/apache/kafka/pull/15015#issuecomment-1862116069 @showuon Some of the existing tests in `DelayedRemoteFetchTest` are failing as the followerFetchParams are passed with a valid replicaId. I took liberty of fixing the existing tests in `D

Re: [PR] KAFKA-16013: Added integration test for ExpiresPerSec metric [kafka]

2023-12-18 Thread via GitHub
satishd commented on code in PR #15015: URL: https://github.com/apache/kafka/pull/15015#discussion_r1429830043 ## core/src/main/scala/kafka/server/DelayedRemoteFetch.scala: ## @@ -41,6 +41,10 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void], re

Re: [PR] KAFKA-16013: Added integration test for ExpiresPerSec metric [kafka]

2023-12-18 Thread via GitHub
showuon commented on PR #15015: URL: https://github.com/apache/kafka/pull/15015#issuecomment-1860028918 @satishd , PR updated. Please check again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t