gharris1727 merged PR #15080:
URL: https://github.com/apache/kafka/pull/15080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-1890150013
Test failures appear unrelated, and the tests pass locally for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gharris1727 commented on code in PR #15080:
URL: https://github.com/apache/kafka/pull/15080#discussion_r1450714324
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -1001,6 +1001,65 @@ public void
developster commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-117897
I've changed the mocks a bit to accommodate both cases, depending on who
executes first: putConnectorConfig or requestTaskReconfiguration. The sleep(10)
is the right amount to wait
developster commented on code in PR #15080:
URL: https://github.com/apache/kafka/pull/15080#discussion_r1450160994
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -1001,6 +1001,48 @@ public void
gharris1727 commented on code in PR #15080:
URL: https://github.com/apache/kafka/pull/15080#discussion_r1442146732
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -1001,6 +1001,48 @@ public void
developster commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-1877282686
@gharris1727 , I've added the test. It first starts the connector, then
updates both the connector and task at the same time. The reason for this is
that task reconfiguration will
gharris1727 commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-1875639893
> just invoking methods in order is not enough to trigger the deadlock. I
believe it is possible to reliably reproduce the deadlock with two countdown
latches, one countdown in the
developster commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-1875320392
@gharris1727 , sure. I wrote the test but just invoking methods in order is
not enough to trigger the deadlock. The requestTaskReconfiguration method is
always executed before
developster commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-1871963622
Sure @vamossagar12 , just tested both unpatched 3.6.1 and patched 3.8.0.
Unpatched version reached deadlock in 40% of the cases (6 out of 15) at the
same time I was unable to
developster opened a new pull request, #15080:
URL: https://github.com/apache/kafka/pull/15080
*Description of the change*
Changed StandaloneHerder to always synchronize on itself before invoking any
methods on MemoryConfigBackingStore. This helped the situation as the order of
11 matches
Mail list logo
