Re: [PR] KAFKA-16094: BrokerRegistrationRequest.logDirs field must be ignorable [kafka]

2024-01-09 Thread via GitHub
cmccabe merged PR #15153: URL: https://github.com/apache/kafka/pull/15153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16094: BrokerRegistrationRequest.logDirs field must be ignorable [kafka]

2024-01-08 Thread via GitHub
cmccabe commented on PR #15153: URL: https://github.com/apache/kafka/pull/15153#issuecomment-1881985343 In addition to the unit test in the PR, I verified manually that the bug is not present after the PR (and is before) -- This is an automated message from the Apache Git Service. To resp

[PR] KAFKA-16094: BrokerRegistrationRequest.logDirs field must be ignorable [kafka]

2024-01-08 Thread via GitHub
cmccabe opened a new pull request, #15153: URL: https://github.com/apache/kafka/pull/15153 3.7 brokers must be able to register with 3.6 and earlier controllers. Currently, this is broken because we will unconditionally try to set logDirs, but this field cannot be sent with BrokerRegistrati