lucasbru merged PR #15210:
URL: https://github.com/apache/kafka/pull/15210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on PR #15210:
URL: https://github.com/apache/kafka/pull/15210#issuecomment-1899847833
Hey @lucasbru - Thanks for your time reviewing this PR. I've made changes
according to your suggestion. Let me know what do you think of the PR.
--
This is an automated message from
philipnee commented on code in PR #15210:
URL: https://github.com/apache/kafka/pull/15210#discussion_r1457711259
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1547,6 +1553,29 @@ public String toString() {
}
}
lucasbru commented on code in PR #15210:
URL: https://github.com/apache/kafka/pull/15210#discussion_r1457244991
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -140,6 +141,7 @@ public class AsyncKafkaConsumerTest {
philipnee commented on code in PR #15210:
URL: https://github.com/apache/kafka/pull/15210#discussion_r1457081393
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1547,6 +1553,29 @@ public String toString() {
}
}
philipnee commented on PR #15210:
URL: https://github.com/apache/kafka/pull/15210#issuecomment-1896275067
@lucasbru - Would you have time to review this? Seems like the failed tests
aren't necessary related.
--
This is an automated message from the Apache Git Service.
To respond to the
philipnee commented on code in PR #15210:
URL: https://github.com/apache/kafka/pull/15210#discussion_r1454575608
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2169,10 +2169,8 @@ public void
philipnee opened a new pull request, #15210:
URL: https://github.com/apache/kafka/pull/15210
In this PR, I'm adding sensor to the `CommitRequestManager` to record the
necessary metrics, i.e.:
```
commit-latency-avg
commit-latency-max
commit-rate
commit-total
