Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

mjsax commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1898958611 Thanks. The fix was pushed after I left my comment. Glad it's resolved. Yeah, I did expect that two overlapping PR got merged simultaneously. -- This is an automated message from th

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

pprovenzano commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1898795980 Looks like it is already fixed with: MINOR: Fix compilation issue in ReplicaManagerTest (

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

mjsax commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1897998713 @pprovenzano @cmccabe -- it seems this PR did break `trunk` build. ``` > Task :core:compileTestScala [Error] /Users/matthias/IdeaProjects/kafka/core/src/test/scala/unit/kafka/se

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

cmccabe merged PR #15197: URL: https://github.com/apache/kafka/pull/15197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

pprovenzano commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1896448532 Test failures are not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

pprovenzano commented on code in PR #15197: URL: https://github.com/apache/kafka/pull/15197#discussion_r1455684322 ## metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java: ## @@ -46,6 +46,18 @@ public final class FeaturesImage { ZkMigrationState.NONE );

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

cmccabe commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1895021752 Thanks for the quick response on this one, @pprovenzano . LGTM once you address the one comment I made. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

cmccabe commented on code in PR #15197: URL: https://github.com/apache/kafka/pull/15197#discussion_r1454694471 ## metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java: ## @@ -46,6 +46,18 @@ public final class FeaturesImage { ZkMigrationState.NONE ); +

Re: [PR] Kafka 16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

pprovenzano commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1894699271 Test failures are unrelated to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Kafka 16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

pprovenzano opened a new pull request, #15197: URL: https://github.com/apache/kafka/pull/15197 We only want to send directory assignments if the metadata version supports it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu