Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac merged PR #15212: URL: https://github.com/apache/kafka/pull/15212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1461110485 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1460376759 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1459490703 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1458570521 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457917435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457917435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457917435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457913561 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -861,19 +861,9 @@ private void maybeUpdatePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac commented on PR #15212: URL: https://github.com/apache/kafka/pull/15212#issuecomment-1898623457 @jeffkbkim i have strengthen the validation around updating the partition epochs in my last commit. with this, the state change that we saw would have been rejected. i think that this is

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac commented on PR #15212: URL: https://github.com/apache/kafka/pull/15212#issuecomment-1898536868 > to confirm, the previousMemberEpoch=11 should be 14 in the given example right? previousMemberEpoch=11 seems correct as the member transitioned from 11 to 15. > this seems

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457480228 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -861,19 +861,9 @@ private void maybeUpdatePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jeffkbkim commented on PR #15212: URL: https://github.com/apache/kafka/pull/15212#issuecomment-1896786496 > when a member has a partition pending revocation re-assigned to him before the revocation is completed, the partition epoch is lost to confirm, the `previousMemberEpoch=11`

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1456314640 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -861,19 +861,9 @@ private void maybeUpdatePartitionEpoch(

[PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

dajac opened a new pull request, #15212: URL: https://github.com/apache/kafka/pull/15212 We had a case where a partition got assigned to two members and we found a bug in the partition epochs bookkeeping. Basically, when a member has a partition pending revocation re-assigned to him before