Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-14 Thread via GitHub
lucasbru merged PR #15334: URL: https://github.com/apache/kafka/pull/15334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-14 Thread via GitHub
cadonna commented on code in PR #15334: URL: https://github.com/apache/kafka/pull/15334#discussion_r1489442547 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1378,6 +1377,14 @@ class PlaintextConsumerTest extends BaseConsumerTest { //

Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-14 Thread via GitHub
lucasbru commented on code in PR #15334: URL: https://github.com/apache/kafka/pull/15334#discussion_r1489269554 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1378,6 +1377,14 @@ class PlaintextConsumerTest extends BaseConsumerTest { //

Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-13 Thread via GitHub
cadonna commented on code in PR #15334: URL: https://github.com/apache/kafka/pull/15334#discussion_r1487471412 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1378,6 +1377,14 @@ class PlaintextConsumerTest extends BaseConsumerTest { //

Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-12 Thread via GitHub
lucasbru commented on PR #15334: URL: https://github.com/apache/kafka/pull/15334#issuecomment-1938263362 @cadonna Could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-07 Thread via GitHub
lucasbru commented on code in PR #15334: URL: https://github.com/apache/kafka/pull/15334#discussion_r1481228908 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1378,6 +1377,14 @@ class PlaintextConsumerTest extends BaseConsumerTest { //

[PR] KAFKA-16155: Re-enable testAutoCommitIntercept [kafka]

2024-02-07 Thread via GitHub
lucasbru opened a new pull request, #15334: URL: https://github.com/apache/kafka/pull/15334 The main bug causing this test to fail as described in the ticket was already fixed. The test is still flaky if unchanged, because in the new consumer, the assignment can change in between